Refactor Zend parameter parsing API #5609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
zpp-refactor-uint
branch
from
d69fa21 to
eb2c622
Compare
nikic
reviewed
May 22, 2020
Girgias
force-pushed
the
zpp-refactor-uint
branch
from
eb2c622 to
5dc964c
Compare
nikic
approved these changes
May 22, 2020
| } | ||
|
|
||
| if (num_args < min_num_args || (num_args > max_num_args && max_num_args >= 0)) { | ||
| if (num_args < min_num_args || (num_args > max_num_args)) { |
There was a problem hiding this comment.
Suggested change
| if (num_args < min_num_args || (num_args > max_num_args)) { | |
| if (num_args < min_num_args || num_args > max_num_args) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the unused
num_argfrom zend_parse_arg_impl and converts all thearg_num(s)to uint32_t as this how they are represented everywhere else.Also change the character during classic ZPP format parsing from int to char as they might not have the same signess depending on platform.
A by-product is that it fixes some [-Wconversion] warnings which should also catch some generated by MSVC